Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native/unreal): Don't overwrite a previously set event level #50717

Merged
merged 6 commits into from
Jun 15, 2023
Merged

fix(native/unreal): Don't overwrite a previously set event level #50717

merged 6 commits into from
Jun 15, 2023

Conversation

bitsandfoxes
Copy link
Contributor

Resolves getsentry/sentry-unreal#189

Events coming from the Unreal Crashreporter already have their level when merging the context in Relay.
If the level already has been set it should not be overwritten.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #50717 (d8e372f) into master (f61ff85) will increase coverage by 20.04%.
The diff coverage is 100.00%.

❗ Current head d8e372f differs from pull request most recent head b50586c. Consider uploading reports for the commit b50586c to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #50717       +/-   ##
===========================================
+ Coverage   61.08%   81.13%   +20.04%     
===========================================
  Files        4840     4839        -1     
  Lines      204000   203694      -306     
  Branches    11130    11159       +29     
===========================================
+ Hits       124623   165268    +40645     
+ Misses      79131    38180    -40951     
  Partials      246      246
Impacted Files Coverage Δ
src/sentry/lang/native/processing.py 87.15% <100.00%> (+2.72%) ⬆️

... and 1622 files with indirect coverage changes

@bitsandfoxes bitsandfoxes requested a review from Swatinem June 14, 2023 15:11
@bitsandfoxes bitsandfoxes marked this pull request as ready for review June 14, 2023 15:11
@bitsandfoxes bitsandfoxes requested a review from a team June 14, 2023 15:11
@bitsandfoxes bitsandfoxes merged commit 33945f4 into master Jun 15, 2023
@bitsandfoxes bitsandfoxes deleted the fix/dont-overwrite-level branch June 15, 2023 13:00
@supervacuus supervacuus mentioned this pull request Jun 21, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@loewenheim loewenheim loewenheim approved these changes

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensures are incorrectly reported to sentry as "Fatal" errors
3 participants
@bitsandfoxes @Swatinem @loewenheim